Repository navigation
CN9130 Watchdog - #1321
Merged
Merged
CN9130 Watchdog#1321
Conversation
By default, ensure that the target device accepts TCP connections on
the specified port before returning the device object. This aligns the
SSH implementation with {NET,REST}CONF.
This solves the issue where tests that use SSH commands early in their
execution would sometimes fail as the remote server had not started up
yet.
Usable by all Server Base System Architecture (SBSA) compliant SoCs, e.g., CN9130.
This will be us the ability to test a hardware watchdog's ability to trigger on different kinds of lockups.
Rev. A has a FLASH that Linux reconfigures to 4B-addressing, but must be in 3B-addressing when accessed by the BootROM. Since it has no reset input, this would not work on warm resets. Linux has a workaround for this issue for the common case of a controlled reboot, which this change enables on those boards (which are admittedly few and far between, but still useful as testing vehicles). (This won't take effect until Finit is updated to at least 4.15, which switches over from watchdog- to reboot(2)- based reboot, by default)
Verify that if the system encounters a hard lockup, i.e., interrupts are no longer being serviced, then the system's watchdog will correctly reboot it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Platforms based on Marvell CN9130 have incorrectly relied on the software watchdog (
softdog) driver for supervision. Switch to the hardware watchdog to ensure that the system is rebooted even in scenarios that the software implementation can not recover from (e.g., hard lockups where interrupts are no longer serviced).While we're here, add a regression test for this feature using the kernel's
test_lockupmodule.Checklist
Tick relevant boxes, this PR is-a or has-a: